[Tickets #12505] Re: Free/busy URL is not found on re-open of events

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | ***@kwsoft.de <***@kwsoft.de>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Unconfirmed
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


***@kwsoft.de (2013-07-26 08:11) wrote:

Creating an event with attendees which have a free/busy URL in the
adressbook set for kronolith works as expected and show the free/busy
information. After saving the event and then reopen it, one always get
the warning "no free/busy URL for <e-mail> found" for all attendees.
So it looks like the search for f/b URL is different for creating and
reopen??

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Michael Rubinsky <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
-State | Unconfirmed
+State | Feedback
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


Michael Rubinsky <***@horde.org> (2013-07-26 13:26) wrote:

Cannot reproduce.

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | ***@kwsoft.de
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Feedback
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------

Post by n***@bugs.horde.org
Cannot reproduce.

It looks like the addressbook used for f/b URL search must have
"use_shares=false", with the personal addressbook it works. So create
a second backend in turba with "use_shares=false" to test. The
question is why there is a difference between creating and opening the
event regarding this.

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | ***@kwsoft.de
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Feedback
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


***@kwsoft.de (2013-07-29 15:01) wrote:

Creating the F/B display is done in Javascript, no? So i have to look
in js/kronolith.js for the difference between creating and updating
the event??

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Michael Rubinsky <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Feedback
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------

Post by n***@bugs.horde.org
Creating the F/B display is done in Javascript, no? So i have to
look in js/kronolith.js for the difference between creating and
updating the event??

Yes, the display is created in javascript, but the freebusy data is
generated in PHP from the getFreeBusy Ajax call
(Kronolith_Ajax_Application_Handler::getFreeBusy()). You can look
there, and also use Firebug or similar tool to see what the Ajax
request is actually sending/receiving.

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Jan Schneider <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
-State | Feedback
+State | No Feedback
Priority | 2. Medium
Milestone |
Patch |
Owners |

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | ***@kwsoft.de
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | No Feedback
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


***@kwsoft.de (2013-09-30 14:57) wrote:

A lowercase search Problem. We had e-mail address like
"***@domain.tld" in the address book. On creating the event this is
stored as "***@domain.tld" and with obviously case-sensitive match
on reopen the address is not found.

Testcase:
Create a contact entry with e-mail like this "***@domain.tld" and a
valid FB-URL. Add this to a new event -> FB Info is shown. Reopen the
event and a FB-URL error is shown and the FB Info is not present any
more.

Is this fixable in the Javascript code?

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | ***@kwsoft.de
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | No Feedback
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


***@kwsoft.de (2013-10-02 14:35) wrote:

in kronolith/lib/FreeBusy.php the Turba getField call is used to fetch
the FB-URL. At this call (around line 254) the parameter strict is set
to "true" which lead to case sensitive search which breaks FB-URL
finding if the email field is used with mixed case like
***@domain. Is it possible to use strict = false or does this
break other things. What kind of "strictness" is enforced with this
parameter??

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Jan Schneider <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
-State | No Feedback
+State | Unconfirmed
Priority | 2. Medium
Milestone |
Patch |
Owners |

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | ***@kwsoft.de
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Unconfirmed
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


***@kwsoft.de (2013-10-16 10:17) wrote:

So this would be the patch to make the search case insensitive, but as
said i don't what other fuzzyness the nonstrict search will result in.

--- kronolith/lib/FreeBusy.php 2013-10-02 16:36:27.000000000 +0200
+++ kronolith/lib/FreeBusy.patch.php 2013-10-16 12:13:50.000000000 +0200
@@ -253,7 +253,7 @@

try {
$result = $GLOBALS['registry']->call('contacts/getField',
- array($email,
'freebusyUrl', $sources, true, true));
+ array($email,
'freebusyUrl', $sources, false, true));
} catch (Horde_Exception $e) {
return false;
}

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | ***@kwsoft.de
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Unconfirmed
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


***@kwsoft.de (2013-11-21 17:21) wrote:

Any one from the developers is able to comment on this?

Thanks

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Michael Rubinsky <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
-State | Unconfirmed
+State | Not A Bug
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


Michael Rubinsky <***@horde.org> (2013-11-21 17:40) wrote:

The patch is technically wrong because according to RFC5321, an email
address may very well be case sensitive.

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | ***@kwsoft.de
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Not A Bug
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


***@kwsoft.de (2013-11-21 17:48) wrote:

Strictly speaking it is possible that the local-part is case
sensitive, the domain part never was. It is also fact that no one sane
in mind ever distinguished between local-part and Local-part. If we go
that road please also "fix" the initial search to not find the address
at all. With this the FB URLs would be finally useless at all.

This RFC part is historically from using login usernames as local-part
which might be case sensitive like in Unix or not like in Windows.
Today there is no real relation between local-part and system accounts
anyway.

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Michael Rubinsky <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Not A Bug
Priority | 2. Medium
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


Michael Rubinsky <***@horde.org> (2013-11-21 18:00) wrote:

In addition, removing the strict match could cause email addresses to
be included that were not meant to be. For instance, it's unlikely,
but ***@example.co would also match ***@example.com. Or
***@example.ne would match ***@example.net.

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Michael Rubinsky <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
-State | Not A Bug
+State | Feedback
-Priority | 2. Medium
+Priority | 1. Low
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


Michael Rubinsky <***@horde.org> (2013-11-21 18:03) wrote:

If anything, we should not be normalizing the email addresses to lower
case when saving them in the Kronolith event since we are not doing
that in Turba.

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | ***@kwsoft.de
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Feedback
Priority | 1. Low
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------


***@kwsoft.de (2013-11-21 20:32) wrote:

First sorry for sounding harsh in the last comment.

It would of course be a win to not lowercase the mailaddress and
afterwards searching case sensitive, yes. IMMHO we should try as hard
as possible to find a useable FB-URL, because they are rare anyway and
even using the wrong one would not be a disaster as the FB-URL is
only a hint for planing anyway.

But this needs fixing in Javascript, no?

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Michael Rubinsky <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Feedback
Priority | 1. Low
Milestone |
Patch |
Owners |
------------------------------------------------------------------------------

Post by n***@bugs.horde.org
First sorry for sounding harsh in the last comment.
It would of course be a win to not lowercase the mailaddress and
afterwards searching case sensitive, yes. IMMHO we should try as
hard as possible to find a useable FB-URL, because they are rare
anyway and even using the wrong one would not be a disaster as the
FB-URL is only a hint for planing anyway.

Well, the problem with that is that the user might not know it's the
wrong FB info. Anyway, your patch won't necessarily solve the issue
in the first place since even a non-strict search on a sql database
that is case sensitive will fail. As far as I know, the strictness
only controls requiring a full equals match vs a wildcard match.

Post by n***@bugs.horde.org
But this needs fixing in Javascript, no?

Not sure if we are normalizing in the js or php off hand.

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Michael Rubinsky <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
-State | Feedback
+State | Resolved
Priority | 1. Low
Milestone |
Patch |
-Owners |
+Owners | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <***@horde.org> (2013-11-23 18:18) wrote:

Kronolith 4.2.0

[n***@bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12505
------------------------------------------------------------------------------
Ticket | 12505
Updated By | Michael Rubinsky <***@horde.org>
Summary | Free/busy URL is not found on re-open of events
Queue | Kronolith
Version | 4.1.2
Type | Bug
State | Resolved
Priority | 1. Low
Milestone |
Patch |
Owners | Michael Rubinsky
------------------------------------------------------------------------------


Michael Rubinsky <***@horde.org> (2013-11-23 18:18) wrote:

http://lists.horde.org/archives/commits/2013-November/022226.html